Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in opengl integration example #1181

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Fix memory leak in opengl integration example #1181

merged 1 commit into from
Jan 3, 2022

Conversation

feylinara
Copy link
Contributor

Fixes issue #1087, where any user input in the opengl integration example would leak memory. This was due to creating a new VAO and program for every call to the event handler.

hecrj
hecrj approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you 🥳

@hecrj hecrj merged commit 14c9380 into iced-rs:master Jan 3, 2022
@hecrj hecrj added the bug Something isn't working label Jan 3, 2022
@hecrj hecrj added this to the 0.4.0 milestone Jan 3, 2022
@derezzedex derezzedex mentioned this pull request Jan 5, 2022
Merged
@hecrj hecrj mentioned this pull request Jan 22, 2022
Closed
@hecrj hecrj mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@feylinara @hecrj